Refactor embed video helper to disconnect from @proposal #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis test has failed due to issue #3421 that is not related to this PR |
voodoorai2000
force-pushed
the
proposals-people
branch
2 times, most recently
from
abfbb49
to
744824e
Compare
javierm
approved these changes
Sep 13, 2019
There was a problem hiding this comment.
These changes make a lot of sense: using instance variables in helpers makes the code very hard to follow.
I'm running the tests on my fork applying this commit to our latest master branch. If everything works properly, I'll merge them.
@abelardogilm Thanks a lot! 😄
|
💪 😄 |
|
The build was green. Merged! 🎉 |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…tor_embedded_video Refactor embed video helper to disconnect from @proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#3471
Objectives
As we are creating a new model using Legislation::Proposal model, refactor embed_videos_helper to be used for another views will reduce and make clear code
Visual Changes
Nothing
Notes
N/A