Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display all polls for current booth #3361

Merged
merged 3 commits into from
May 28, 2019
Merged

Display all polls for current booth #3361

merged 3 commits into from
May 28, 2019

Commits on May 24, 2019

  1. Display polls for current booth 

    Polls that were not votable by a user were not being displayed in the officing interface. Creating a confusing situation for officers.

With this commit polls that are not votable by a user will be displayed, with the corresponding message explaining that that poll can only be voted by residents of a certain geozone.
    @voodoorai2000 @javierm
    voodoorai2000 authored and javierm committed May 24, 2019
    Configuration menu
    Copy the full SHA
    29f5268 View commit details
    Browse the repository at this point in the history

  2. Simplify html tag structure

    @voodoorai2000 @javierm
    voodoorai2000 authored and javierm committed May 24, 2019
    Configuration menu
    Copy the full SHA
    5abde6d View commit details
    Browse the repository at this point in the history

  3. Display already voted message for budget polls 

    Budget polls behave slightly differently to non-budget polls.

In budget polls we use Budget::Ballot::Lines to verify if a user has already voted online. In non-budget polls we use Poll::Voter to verify this.

In this commit we are adding an extra check to make sure that the correct message is displayed if the user has already voted online for a budget poll[1]

[1] https://github.com/AyuntamientoMadrid/consul/blob/master/spec/features/budget_polls/voter_spec.rb#L122
    @voodoorai2000 @javierm
    voodoorai2000 authored and javierm committed May 24, 2019
    Configuration menu
    Copy the full SHA
    e1141d1 View commit details
    Browse the repository at this point in the history