[Backport] Make budgets translatable #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sluggable models can update the slug when updating new translations, so we make sure the path is correct before using it.
Sometimes when updating a resource you are not redirected to the same resource, you are maybe redirected to the parent resource and the translations can be different. This condition will be checked after visiting the edit_path again.
When more than one ckeditor field this line was raising the error: "Ambiguous match, found 2 elements matching visible css"
houndci-bot
reviewed
Feb 13, 2019
microweb10
force-pushed
the
make_budgets_translatable
branch
from
5fe7517
to
94a4c06
Compare
microweb10
force-pushed
the
make_budgets_translatable
branch
from
94a4c06
to
ec5339a
Compare
houndci-bot
reviewed
Feb 13, 2019
microweb10
commented
Feb 13, 2019
| end | ||
|
|
||
| def name_exists_in_budget_headings |
There was a problem hiding this comment.
Removed this method cause it wasn´t being used along the project.
microweb10
force-pushed
the
make_budgets_translatable
branch
from
ec5339a
to
a963a99
Compare
Since we have a method defined inside the Globalizable module we don't need to create the same method in every model
javierm
approved these changes
Feb 13, 2019
voodoorai2000
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of 2 PRs AyuntamientoMadrid#1842 and AyuntamientoMadrid#1875
Objectives
Make participatory budgets translatable.
Visual Changes
BUDGETS
BUDGET PHASES
BUDGET GROUPS
BUDGET HEADINGS
Notes
closes #2737