-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sass-rails gem by sassc-rails #3286
Replace sass-rails gem by sassc-rails #3286
Conversation
One failed spec so far:
|
OK, seems like it's just a flaky. |
Thanks @milovanderlinden, @PierreMesure! We are still analysing the system dependencies that this gem has and the consequences for forks. We'll come back to it 👍 |
55682c8
to
ff20467
Compare
ff20467
to
f2fe0f2
Compare
Just for the record, the reason we haven't approved this change yet is it broke the installation in the system we tried it (Madrid's preproduction server). It looks like the required version of GCC was not installed on that server, as mentioned in AyuntamientoMadrid#70. So we need to consider some CONSUL installations will crash if we use On the other hand, distributions we officially support would not be affected... |
After investigating this topic, it looks like everything will be fine with systems with GCC >= 4.7 (released in 2012). Madrid is probably the only place where this will be an issue, since they've got GCC 4.4. @PierreMesure Could you rebase this pull request and use double quotes instead of single quotes? 🙏 After that, I think it'll be safe to merge it. |
f2fe0f2
to
f03e320
Compare
f03e320
to
213903a
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PierreMesure Thank you very much! 🎉
…s-by-sassc Replace sass-rails gem by sassc-rails
References
Objectives
Notes
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal in Sass 4.0. Use call(get-function("shake")) instead.