Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Change layout on homepage if feed debates and proposals are enabled #3269

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Feb 5, 2019

References

This is a backport of AyuntamientoMadrid#1859

Background

Admin users can enable show proposals and debates feed on homepage from /admin/homepage but if only enable one the layout looks empty with too much blank space.

Objectives

Change layout on homepage if feed debates and proposals are enabled. Now show the content with 100% width if only proposals or debates are enabled.

Visual Changes

Feeds proposals and debates enabled (same layout)
proposals_debates

Only feed proposals, 100% width!
proposals

Only feed debates, 100% width!
debates

@decabeza decabeza self-assigned this Feb 5, 2019
@decabeza decabeza added this to Review in Roadmap Feb 5, 2019
@milovanderlinden
Copy link

You can see in the travis log that there is a failed test:

Failures:
  1) Legislation Proposals Random pagination Each user has a different and consistent random proposals order
     Failure/Error: expect(legislation_proposals_order).to eq(@first_user_proposals_order)
       expected: ["legislation_proposal_9", "legislation_proposal_9_votes", "legislation_proposal_5", "legislation_pro...osal_3", "legislation_proposal_3_votes", "legislation_proposal_11", "legislation_proposal_11_votes"]
            got: ["legislation_proposal_6", "legislation_proposal_6_votes", "legislation_proposal_10", "legislation_pr...osal_12", "legislation_proposal_12_votes", "legislation_proposal_4", "legislation_proposal_4_votes"]
       (compared using ==)
     # ./spec/features/legislation/proposals_spec.rb:51:in `block (4 levels) in <top (required)>'
     # ./spec/sessions_helper.rb:2:in `in_browser'
     # ./spec/features/legislation/proposals_spec.rb:49:in `block (3 levels) in <top (required)>'

Please make sure this test passes when there are no proposals.

@decabeza
Copy link
Collaborator Author

decabeza commented Feb 6, 2019

Hi @milovanderlinden,

This failed spec it's a Flaky spec (we have an issue to fix it on AyuntamientoMadrid#1659) and is not related with the changes of this PR.

😉

@decabeza decabeza merged commit 14e73e9 into master Feb 6, 2019
@decabeza decabeza deleted the homepage-feeds branch February 6, 2019 13:32
@decabeza decabeza moved this from Review to Release 0.19 in Roadmap Feb 6, 2019
@javierm
Copy link
Member

javierm commented Feb 26, 2019

@milovanderlinden The mentioned failure should be fixed by #3321. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants