Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow select column width for widget cards #3252

Merged
merged 8 commits into from
Feb 5, 2019
Merged

Conversation

decabeza
Copy link
Collaborator

References

Add cards to custom pages #3149

Background

Admins can create cards for homepage on /admin/widget/cards/new and since #3149 also for custom pages on /admin/widget/cards/new?page_id=N.

Objectives

  • Add columns to widget cards: this add a select on each card new form to select the number of columns for their width (for a better UX on mobile screens it's always 100%)
  • Improve notice message for pages cards.
  • Improve CSS layout.
  • Show card label only if it is present: until now was showing an empty span.
  • Remove unnecessary title on page cards: on custom pages a "Featured title" is not necessary.
  • Add columns on welcome card view: I include this feature for the cards created for the homepage.
  • Fix hound warnings. Clean code! ✊🤓

Notes

For cards you can use from 1 to 12 columns, based on [Foundation Float Grid].(https://foundation.zurb.com/sites/docs/grid.html)

Visual Changes

New select on admin card new form
screenshot 2019-01-31 at 15 53 34
screenshot 2019-01-31 at 15 53 40

Now you can create more interesting layouts
layout

BEFORE if a card didn't have a label show a blank span
screenshot 2019-01-31 at 14 10 49

Now show card label only if it is present
screenshot 2019-01-31 at 14 11 03

You can use from 1 to 12 columns
screenshot 2019-01-31 at 14 34 32
2

@decabeza decabeza self-assigned this Jan 31, 2019
@decabeza decabeza added this to Review in Roadmap Jan 31, 2019
@decabeza decabeza merged commit 282ae61 into master Feb 5, 2019
@decabeza decabeza deleted the custom-pages-cards branch February 5, 2019 16:38
@decabeza decabeza moved this from Review to Upstream in Roadmap Feb 5, 2019
@decabeza decabeza moved this from Upstream to Release 0.19 in Roadmap Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants