Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Refactor milestones css #3196

Merged
merged 5 commits into from
Jan 24, 2019
Merged

[Backport] Refactor milestones css #3196

merged 5 commits into from
Jan 24, 2019

Conversation

decabeza
Copy link
Collaborator

References

This is a backport of AyuntamientoMadrid#1805

Issue consul#3135

Objectives

Make it easier to understand and change the CSS rules related to displaying milestones.

Using `nth-child(odd), nth-child(even)` is the same as selecting all
the elements.
The selector `nth-child(even)` didn't need specific rules, and it's
easier to understand the code for the selector `nth-child(odd)` if all
breakpoints are grouped together.
@voodoorai2000 voodoorai2000 added this to Review in Roadmap Jan 22, 2019
@decabeza decabeza self-assigned this Jan 24, 2019
@decabeza decabeza merged commit 25b56e8 into master Jan 24, 2019
@decabeza decabeza deleted the refactor_milestones_css branch January 24, 2019 11:02
@decabeza decabeza moved this from Review to Release 0.19 in Roadmap Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants