[Backport] Enable useless assignment rubocop rule #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way deverlopers who don't run the ruby syntax check locally with warnings enabled will be informed by HoundCI.
javierm
force-pushed
the
backport-enable_useless_assignment_rule
branch
from
985d1e4
to
a69004a
Compare
voodoorai2000
approved these changes
Feb 15, 2019
|
Travis failure isn't related to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Help developers who don't run the ruby syntax check locally realize they might be involuntarily assigning a value to a local variable which is never used, and so they might want to check whether they need to refactor the code a bit.