Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix flaky spec: Welcome screen is not shown to organizations #3072

Merged
merged 3 commits into from
Nov 30, 2018
Merged

[Backport] Fix flaky spec: Welcome screen is not shown to organizations #3072

merged 3 commits into from
Nov 30, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Nov 30, 2018 •
edited
Loading

References

Notes

  • Part of the code changed in the original pull request doesn't exist in CONSUL, and so there was no need to change it
  • The file spec/spec_helper.rb is now identical to the one in Madrid's fork

@javierm
Reset page driver after every spec using it
2f86023 
There were some issues because some specs  directly used the driver but
didn't reset it after the test.
@javierm
Remove redundant Capybara actions
b153f5f 
Resetting sessions and driver is automatically done by requiring
'capybara/rspec', as shown by the (lack of) that configuration for RSpec
in the Capybara README, manual testing of those settings, and Capybara's
code itself.
@javierm javierm merged commit 7446ebb into master Nov 30, 2018
@javierm javierm deleted the backport-1623-fix_flaky_driver_session branch November 30, 2018 13:14
@javierm javierm self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decabeza decabeza decabeza approved these changes

Assignees

@javierm javierm

Labels
Flaky spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky spec: Welcome screen is not shown to organizations
2 participants
@javierm @decabeza