Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix flaky spec: Admin legislation draft versions Update Valid legislation draft version #2995

Merged
merged 1 commit into from
Oct 31, 2018
Merged

[Backport] Fix flaky spec: Admin legislation draft versions Update Valid legislation draft version #2995

merged 1 commit into from
Oct 31, 2018

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 31, 2018

@javierm
Don't check already present page content
5345b56 
The content 'An example legislation process' is already present before
we click the "All" link.

Not checking the page content properly sometimes resulted in the second
click being executed before the first request had been completed, making
the spec fail.

By checking the "All" link isn't present anymore, we guarantee the
request has been completed before trying to click the 'An example
legislation process' link.
@javierm javierm merged commit d78b1c1 into master Oct 31, 2018
@javierm javierm deleted the backport-1618-fix_flaky_draft_versions_spec branch October 31, 2018 12:12
@javierm javierm mentioned this pull request Nov 13, 2018
Closed
@javierm javierm self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decabeza decabeza decabeza approved these changes

Assignees

@javierm javierm

Labels
Flaky spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky spec: Admin legislation draft versions Update Valid legislation draft version
2 participants
@javierm @decabeza