Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed icon_home and fixed corresponding test #2970

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Removed icon_home and fixed corresponding test #2970

merged 1 commit into from
Nov 27, 2018

Conversation

PierreMesure
Copy link
Collaborator

References

#2853

Objectives

  • Removes the icon_home from the list in the settings
  • Changes the spec that was testing an invalid image on its uploader

Visual Changes

capture d ecran 2018-10-12 a 10 02 17

capture d ecran 2018-10-12 a 10 02 30

@voodoorai2000 voodoorai2000 added this to Review in Roadmap Oct 17, 2018
@voodoorai2000
Copy link
Member

Thank you @PierreMesure! 🎉

@voodoorai2000 voodoorai2000 merged commit e23fbc8 into consuldemocracy:master Nov 27, 2018
@voodoorai2000 voodoorai2000 moved this from Review to Release 0.18 in Roadmap Dec 3, 2018
@PierreMesure PierreMesure deleted the Remove-icon-png-from-settings branch June 14, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decabeza decabeza decabeza approved these changes

Assignees

@PierreMesure PierreMesure

Labels
UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PierreMesure @voodoorai2000 @decabeza