Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display language name or language key #2949

Merged
merged 7 commits into from
Oct 10, 2018
Merged

Display language name or language key #2949

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a02619
Display language name or language key
voodoorai2000 Oct 4, 2018
66c9f67
Removes obsolete locale keys for language names
voodoorai2000 Oct 4, 2018
9d7042c
Adds missing language name translations
voodoorai2000 Oct 4, 2018
168ebe3
Fix i18n task' specs
voodoorai2000 Oct 4, 2018
ad51109
Remove duplicate language translation
voodoorai2000 Oct 5, 2018
6f978b9
Fix portuguese specs
voodoorai2000 Oct 9, 2018
59b3515
Fix flaky spec
voodoorai2000 Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix flaky spec 
`I18n.available_locales=` does a little magic[1] and was causing some flakieness along the way, as the `:wl` locale persisted in future specs

Thanks for the heads up @javierm 👌

[1] https://www.rubydoc.info/github/svenfuchs/i18n/I18n%2FConfig:available_locales=
  • Loading branch information
@voodoorai2000
voodoorai2000 committed Oct 9, 2018
commit 59b35156b1f488b0e81e4112dfa4613c897b51de
2 changes: 1 addition & 1 deletion spec/features/localization_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

before do
I18n.enforce_available_locales = false
I18n.available_locales << :wl
I18n.available_locales = default_locales + [:wl]
I18n.locale = :wl
end

Expand Down