[Backport] Make collaborative legislation translatable #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to its markdown editor, the admin draft version page requires JS to correctly render the draft version form.
They were accidentally changed from `text_area` to `text_field` when making them translatable.
There's no reason to only convert Markdown to HTML in translations when their body changes but to always convert it when the "main" body field changes. Whether we should always use the condition or never use it is something we can debate about, though.
We were expecting translation parameters in legislation processes `update` action. However, those parameters aren't sent when we get to that action through the "proposals" tab.
voodoorai2000
approved these changes
Sep 24, 2018
javierm
deleted the
backport-make-collaborative-legislation-translatable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Quoting from AyuntamientoMadrid#1628 (all credit to Marko):
Notes