Improve Github's Pull Request Template file #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaCheca
approved these changes
Mar 5, 2018
voodoorai2000
approved these changes
Mar 5, 2018
|
I just remembered we mentioned using |
The actual PR template feels more like bureaucracy than an actual guide or checklist to help the PR author explain all important thigs that any reviewer or changelog reader may need to understand. We'll be moving most of the redundant things (like remembering tests are needed, or explaning how things where implemented with a clear and granular commit history) into a Wiki/Doc entry. For regular contributors there is no need for reminders, we need to improve new contributors landing with good guides and lowering the bar for first PR's
bertocq
force-pushed
the
improve_pull_request_template
branch
from
3cf0a7e
to
d0c7bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
The actual PR template feels more like bureaucracy than an actual guide
or checklist to help the PR author explain all important thigs that any
reviewer or changelog reader may need to understand.
We'll be moving most of the redundant things (like remembering tests are
needed, or explaning how things where implemented with a clear and
granular commit history) into a Wiki/Doc entry.
For regular contributors there is no need for reminders, we need to
improve new contributors landing with good guides and lowering the bar
for first PR's
Visual Changes (if any)
None
Deployment & Warnings
None