Admin emails list download #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaCheca
force-pushed
the
2120-admin_emails_list
branch
2 times, most recently
from
ccc1371
to
7961632
Compare
MariaCheca
force-pushed
the
2120-admin_emails_list
branch
from
7961632
to
fe20052
Compare
Removed original method to return emails file from Newsletters controller and NewsletterZip class, included `rubyzip` gem that's no longer necessary.
We have a custom implementation to avoid doble submissions which causes some custom problems 😌 This commit should fix the following three specs spec/features/comments/legislation_annotations_spec.rb:367 spec/features/comments/legislation_questions_spec.rb:333 spec/features/custom/probe_option_comments_spec.rb:298 One of the custom problems comes from ajax:success[1] not being triggered, instead only ajax:complete seems to be triggered We should remove this custom implementation and use the standard solution provided in rails[2] [1] https://github.com/AyuntamientoMadrid/consul/blob/master/app/assets/java scripts/prevent_double_submission.js.coffee#L28 [2] https://stackoverflow.com/questions/9570912/how-to-disable-a-form-submit -button-a-l%C3%A0-ruby-on-rails-way/9572893#9572893
bertocq
force-pushed
the
2120-admin_emails_list
branch
from
0e191c3
to
f873bff
Compare
|
Travis builds has only flakies ✅ to merge! |
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…_list Admin emails list download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Replaced old admin functionality to download all users emails in a text file with this new one that downloads in a CSV file the emails list of different user segments.
Screenshots
Test
As usual.
Warnings