Fixed flaky spec: missing comment on legislation annotation

[raul-fuentes]

Where

• Related Issue: Hunt the flaky - Commenting legislation questions Turns links into html links AyuntamientoMadrid/consul#1180
• Related PR's: Flaky error when comment isn't assigned to the legislation proposal AyuntamientoMadrid/consul#1232

What

Fix flaky spec, rspec ./spec/features/comments/legislation_annotations_spec.rb:139

How

Explained in the related PR.

Screenshots

There aren't

Test

Explained in the related PR

Deployment

Nothing to apply

Warnings

Nothing to apply

[javierv]

@raul-fuentes @bertocq I've just seen this test fail on my machine on the master branch; could it be possible that it still happens sometimes? Sorry to bring bad news!

EDIT: confirmed on my machine this test fails once in a while, with the same frequency as failures 2 and 3 mentioned in a hunt flaky test comment.

I think it might be related to postgresql fetching the comments in random order, like it happened with emails in #2695. The test looks for the last comment shown on the page, but that doesn't have to be the last comment created (which is what the test expects). This behaviour is hinted by the failure message:

expected to find text "Built with http:https://rubyonrails.org/" in "Manuela582 • Author • 2018-01-30 23:28:26 a comment No votes | I agree 0 I disagree 0 No responses"

Note "a comment" is the text of the other comment created during the test.

@raul-fuentes Do you think this could be the reason why this test still fails sometimes?

[javierv]

@raul-fuentes @bertocq Here's a recent build showing one of the mentioned failures: https://travis-ci.org/javierv/consul/jobs/400994553

  1) Commenting legislation questions Sanitizes comment body for security
     Failure/Error: expect(page).to have_content "click me http:https://www.url.com"
       expected to find text "click me http:https://www.url.com" in "Manuela3027 • Author • 2018-07-06 21:18:22 a comment No votes | I agree 0 I disagree 0 No responses"
     # ./spec/features/comments/legislation_annotations_spec.rb:164:in `block (3 levels) in <top (required)>'
     # ./spec/features/comments/legislation_annotations_spec.rb:163:in `block (2 levels) in <top (required)>'

Just like the other test, the text "a comment" appears where the expected comment was supposed to be.