Only change budget slugs if its on draft phase #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertocq
changed the title
Slugs should only be updated on certain conditions, we need a trait that meets that conditions and the name of the trait passed as a mandatory & named argument on the sluggable concern
bertocq
force-pushed
the
slug_generation_logic
branch
from
400241d
to
e0871e5
Compare
voodoorai2000
approved these changes
Feb 5, 2018
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…ogic Only change budget slugs if its on draft phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
If a Budget is not on Drafting phase, the public urls for the Budget/Budget::Headings/Budget::Groups/Budget::Investments should not change as if those are published online/offline they will send users to 404 errors.
How
Only set a slug value if its not present or conditions are met (budget must be drafting) e0871e5
Screenshots
No need, backend only feature. See tests
Test
8e6e360
Deployment
As usual
Warnings
This new behaviour may be as unintuitive for the admin as the current one... we're not showing the budget/budget group/budget heading slugs anywhere at the admin panel/forms... neither communicating when slugs are changed. I've created an issue to allow slug view/change (with clear & big disclaimers & warnings) here #2433