Remove usage of Investment's internal_comments #2404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Internal Comments textarea on Budget Investments is deprecated and will be entirely removed on release v0.14, for now we're just removing usage for release v0.13.
Since internal comments have been in use in production environments, we need to preserve them. The most basic option is to just create an initial comment on the new internal comments thread with the entire
internal_comments
text and make the first Admin the author.How
Screenshots
Before
Admin Show [Before]
Valuation Form [Before]
Valuation Show [Before]
After
Admin Show [After]
Valuation Form [After]
Valuation Show [After]
Test
Updated those scenarios that were expecting the internal_comments textarea usage
Deployment
This PR assumes that #2403 has been already merged (the rake task in particular)
Warnings
internal_comments
column will be removed from the database. Please ensure you'll be migrating existing values either with the provided rake taskrake investments:internal_comments:migrate_to_thread
or a custom/manual one.