Show investment links only on phase balloting or later #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertocq
reviewed
Jan 26, 2018
app/helpers/budgets_helper.rb
Outdated
| @@ -1,5 +1,9 @@ | |||
| module BudgetsHelper | |||
|
|
|||
| def show_links_to_budget_investments(budget) | |||
| ['reviewing_ballots', 'finished'].include? budget.phase | |||
There was a problem hiding this comment.
Maybe I wasn't explicity enough, but with current budget is on Balloting phase or later (reviewing_ballots or finished) I actually meant balloting phase plus those two next phases as well.
There was a problem hiding this comment.
I'll fix the misunderstanding in a moment.
…iewing_ballots or finished
…stment links over ths changes of the buget's phase
bertocq
force-pushed
the
2377_show_investment_links_only_on_balloting_or_later
branch
from
f6b77a8
to
ecdbc4a
Compare
bertocq
approved these changes
Feb 10, 2018
bertocq
changed the title
aitbw
deleted the
2377_show_investment_links_only_on_balloting_or_later
branch
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…vestment_links_only_on_balloting_or_later Show investment links only on phase balloting or later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
How
Screenshots
Test
Deployment
Warnings