Add alert message when a user deletes an investment project from "My activity" #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2018 16:54
… don't delete their investmentes accidentally
…f the user dismisses the confirm dialog
|
Awesome 🎉 Feel free to include tests in the main commit 👌 |
This was referenced Feb 15, 2018
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…elete-investment-project Add alert message when a user deletes an investment project from "My activity"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Add an alert message when the user clicks delete (a budget_investment) to avoid to removing them accidentally.
How
Add a confirm data attribute to the link to lauch the alert dialog.
Screenshots
Test
A new scenario was created to test if the dialog works. If the user dismisses the dialog the investment is not delted; if it accepts, it's deleted.
Deployment
Nothing to apply.
Warnings
Nothing to apply.