Allow admins to edit Budget phases #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaCheca
force-pushed
the
2339-admin_budgets_phases
branch
from
812204c
to
7ce9de0
Compare
MariaCheca
force-pushed
the
2339-admin_budgets_phases
branch
from
7ce9de0
to
6a8e50e
Compare
MariaCheca
force-pushed
the
2339-admin_budgets_phases
branch
from
6a8e50e
to
2d2c88c
Compare
bertocq
force-pushed
the
2339-admin_budgets_phases
branch
from
f17455b
to
c5c876c
Compare
Why: The Admin Budget form has a submit button for saving the record, adding another submit input to destroy the record actually adds to the html: `<input type="hidden" name="_method" value="delete">` and it collides with the save button, forcing it to perform a destroy instead of save. Previously the destroy button was not in the same div as the save button How: Just changing the Destroy from a button_to to a link_to.
bertocq
force-pushed
the
2339-admin_budgets_phases
branch
from
c5c876c
to
8eaf098
Compare
bertocq
approved these changes
Jan 20, 2018
| @@ -3,6 +3,7 @@ class Phase < ActiveRecord::Base | |||
| PHASE_KINDS = %w(drafting accepting reviewing selecting valuating publishing_prices balloting | |||
| reviewing_ballots finished).freeze | |||
| PUBLISHED_PRICES_PHASES = %w(publishing_prices balloting reviewing_ballots finished).freeze | |||
| SUMMARY_MAX_LENGTH = 1000 | |||
voodoorai2000
added a commit
to AyuntamientoMadrid/consul
that referenced
this pull request
Jan 22, 2018
The budget phase dates are incorrect, changing them from the console is a little cumbersome. We have a PR ready to merge which should make things easier consuldemocracy#2353
decabeza
pushed a commit
to AyuntamientoMadrid/consul
that referenced
this pull request
Jan 22, 2018
The budget phase dates are incorrect, changing them from the console is a little cumbersome. We have a PR ready to merge which should make things easier consuldemocracy#2353
This was referenced Jan 22, 2018
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…s_phases Allow admins to edit Budget phases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Screenshots
Test
As usual.