Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polls manual recounts #1764

Merged
merged 3 commits into from
Jul 24, 2017
Merged

Conversation

bertocq
Copy link
Collaborator

@bertocq bertocq commented Jul 23, 2017

Where

What

  • On this PR we're only removing the Poll::Recount model and any usage on both officing backend and admin backend

How

  • Following steps on issue to get to the pages to be removed, and deleting both views and controllers.
  • Finding any usage of Recount model and relationships on controllers and views (and removing it)
  • Finally removing the Poll::Recount model and database table & indexes

Screenshots

Removed "Store Recount" menu

screen shot 2017-07-20 at 12 29 26

Removed daily recount

screen shot 2017-07-20 at 12 43 07

Removed accumulated daily recount

screen shot 2017-07-20 at 12 42 16

Test

  • Picked certain parts to be removed.

Deployment

  • As usual

Warnings

  • Many features that are present on Madrid are still not here.
  • Poll::FinalRecount features will be removed on next PR to avoid too much things to review just in one (altough model will be kept for history purposes)

@voodoorai2000
Copy link
Member

👌

@bertocq bertocq merged commit 7793673 into master Jul 24, 2017
@bertocq bertocq deleted the feature/1739#remove_polls_manual_recounts branch July 24, 2017 09:10
@bertocq bertocq changed the title Feature/1739#remove polls manual recounts Remove polls manual recounts Nov 27, 2017
javierm pushed a commit to javierm/consul that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants