Allow social image tags to be overwritten #1756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
We had some problems setting a custom twitter & facebook image for the share cards on Madrid's fork https://github.com/AyuntamientoMadrid/consul/blob/stable/app/views/budgets/results/show.html.erb#L4-L11
What
How
Screenshots
No need (to test, its needed a server that both facebook and twitter card debuggers can hit and scan) It was tested on Madrid's development servers for some minutes
https://developers.facebook.com/tools/debug/
https://cards-dev.twitter.com/validator
Test
No actual use on the consul codebase, this is just a small feature for the forks. Worth a feature spec for it?
Deployment
Warnings