Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: consuldemocracy/consuldemocracy Loading
base: 522660a
Choose a base ref
...
head repository: consuldemocracy/consuldemocracy Loading
compare: 249bd9d
Choose a head ref
  • 12 commits
  • 37 files changed
  • 1 contributor

Commits on Dec 22, 2020

  1. Add empty SDG goal show page 

    Note we're using the code instead of the ID to get the goal in the URL.
IMHO this is what most people would expect; visiting a URL with a "7"
takes you to SDG number 7, and not to the one with "7" as a database ID.

In order to avoid tests (either automated tests or manual tests) passing
by coincidence due to the goal ID and the goal code being the same, I'm
shuffling the codes before entering them in the databse.

I've tried using `resolve` in the routes so the code is automatically
taken into account, but it doesn't work since `resolve` cannot be used
inside a namespace, and here we're within the `sdg` namespace.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    9917838 View commit details
    Browse the repository at this point in the history

  2. Add basic header to SDG goals view

    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    a7cfd58 View commit details
    Browse the repository at this point in the history

  3. Use different backgound colors for different goals 

    The same way it's done by the United Nations.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    6b79509 View commit details
    Browse the repository at this point in the history

  4. Extract components for feeds

    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    631f3a3 View commit details
    Browse the repository at this point in the history

  5. Simplify debates and proposals feed layout 

    Using the `:only-child` selector we can adjust widths with CSS and don't
have to rely on methods calculating which features are available.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    829bbeb View commit details
    Browse the repository at this point in the history

  6. Use flex layout instead of data-equalizer in feeds 

    Using data-equalizer is always hard due to the JavaScript it uses, while
the flex layout works all the time.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    46d847c View commit details
    Browse the repository at this point in the history

  7. Reuse code between feed components 

    They were all following the same format.

Note we need to group the `see_all` translation keys together (the same
way it's done with the `most_active` keys) so we don't have an unused
translation warning.

We're also moving the "see all" link in processes outside the feed
content; the same way it's done in debates and proposals and removing
unnecessary classes in the processes feed: the column class is causing
the processes not to be aligned with the debates above them, and the
margin bottom is not needed because the margin of the footer is already
enough.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    0396ced View commit details
    Browse the repository at this point in the history

  8. Render participation feeds per SDG TODO: case of no items

    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    48b0898 View commit details
    Browse the repository at this point in the history

  9. Make "see all" links filter per goal

    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    ab47d91 View commit details
    Browse the repository at this point in the history

  10. Separate the header from the feed content 

    We were having some style issues when adding the processes feed to the
goal view because of this lack of separation.

We're using a <section> tag so it's clear where the <header> tag belongs
to.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    5792d7f View commit details
    Browse the repository at this point in the history

  11. Use h2 tags in feed headers 

    We were jumping from h1 to h3 and some of these sections (cards and
processes) had h3 tags inside them.

My best guess is we were using h3 so the titles were smaller. So I'm
adding a CSS mixin to easily use a font size of a different heading tag.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    c9a3dcc View commit details
    Browse the repository at this point in the history

  12. Add processes to goal view 

    Note the link to see all processes does not filter by goal because the
legislation section does not have any search filters.
    @javierm
    javierm committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    249bd9d View commit details
    Browse the repository at this point in the history
Loading