Add and apply Style/ArrayIntersect rubocop rule

The `intersect?` method has been added in Ruby 3.1, and it's more readable than `(a & b).any?`.
consuldemocracy · Sep 7, 2023 · e19bb6e · e19bb6e
1 parent a24ca70
commit e19bb6e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -603,6 +603,9 @@ Style/AndOr:
 Style/ArrayCoercion:
  Enabled: true
 
+Style/ArrayIntersect:
+ Enabled: true
+
 Style/BlockDelimiters:
  Enabled: true
 

diff --git a/app/helpers/translatable_form_helper.rb b/app/helpers/translatable_form_helper.rb
@@ -8,7 +8,7 @@ def translations_interface_enabled?
  end
 
  def backend_translations_enabled?
- (controller.class.module_parents & [Admin, Management, Valuation, SDGManagement]).any?
+ controller.class.module_parents.intersect?([Admin, Management, Valuation, SDGManagement])
  end
 
  def highlight_translation_html_class

diff --git a/app/models/sdg/process_enabled.rb b/app/models/sdg/process_enabled.rb
@@ -43,6 +43,6 @@ def module_name
  def relatable?
  return true if controller_path_name?
 
- (SDG::Related::RELATABLE_TYPES & [record_or_name.class.name, record_or_name]).any?
+ SDG::Related::RELATABLE_TYPES.intersect?([record_or_name.class.name, record_or_name])
  end
 end