Merge pull request #3313 from consul/backport-fix_literal_as_condition

Fix literal as condition
consuldemocracy · Feb 18, 2019 · 44483c2 · 44483c2
2 parents 8156152 + e11b9dd
commit 44483c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.rubocop_basic.yml b/.rubocop_basic.yml
@@ -30,6 +30,9 @@ Layout/TrailingBlankLines:
 Layout/TrailingWhitespace:
  Enabled: true
 
+Lint/LiteralAsCondition:
+ Enabled: true
+
 Lint/UselessAssignment:
  Enabled: true
 

diff --git a/app/models/budget/investment.rb b/app/models/budget/investment.rb
@@ -95,7 +95,7 @@ class Investment < ActiveRecord::Base
  scope :for_render, -> { includes(:heading) }
 
  before_save :calculate_confidence_score
- after_save :recalculate_heading_winners if :incompatible_changed?
+ after_save :recalculate_heading_winners
  before_validation :set_responsible_name
  before_validation :set_denormalized_ids