Allow filtering by local target in SDG management

consuldemocracy · Jan 23, 2021 · 24a35be · 24a35be
1 parent 6470ff8
commit 24a35be
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/app/models/sdg/local_target.rb b/app/models/sdg/local_target.rb
@@ -17,6 +17,10 @@ class SDG::LocalTarget < ApplicationRecord
 
  belongs_to :target
 
+ def self.[](code)
+ find_by!(code: code)
+ end
+
  def <=>(any_target)
  if any_target.class == self.class
  [target, numeric_subcode] <=> [any_target.target, any_target.numeric_subcode]

diff --git a/spec/system/sdg_management/relations_spec.rb b/spec/system/sdg_management/relations_spec.rb
@@ -168,11 +168,10 @@
  end
 
  scenario "local target filter" do
- schools = create(:sdg_local_target, code: "4.1.1")
- teachers = create(:sdg_local_target, code: "4.1.2")
-
- create(:debate, title: "Rebuild local schools", sdg_local_targets: [schools])
- create(:debate, title: "Hire teachers", sdg_local_targets: [teachers])
+ create(:sdg_local_target, code: "4.1.1")
+ create(:sdg_local_target, code: "4.1.2")
+ create(:debate, title: "Rebuild local schools", sdg_local_targets: [SDG::LocalTarget["4.1.1"]])
+ create(:debate, title: "Hire teachers", sdg_local_targets: [SDG::LocalTarget["4.1.2"]])
 
  visit sdg_management_debates_path
  select "4.1.1", from: "target_code"