Develop #30
Open
Develop #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… articles isn't working
| const title = (article.title !== null) ? `<div><strong>${convertedTitle}</strong></div>` : ""; | ||
| const convertedDescription = (article.description !== null) ? highlightFoundWords(article.description) : null; | ||
| const description = (article.description !== null) ? `<div>${convertedDescription}</div>` : ""; | ||
| // const content = (article.content !== null) ? `<div>${article.content}</div>` : ""; |
There was a problem hiding this comment.
commented out code can be removed
| const separator = (author && source) ? ", " : ""; | ||
| const publishedBy = `<div><cite>Published by: ${author}${separator}${source}</cite></div>`; | ||
| const readMoreURL = (article.url !== null) ? `<div><a href="${article.url}" target="_blank">READ FULL STORY...</a></div>` : ""; | ||
| // const urlToImage = (article.urlToImage !== null) ? `<a href="${article.url}" target="_blank"><img src="${article.urlToImage}" class="article__image__src"></a>` : ""; |
| // toggle show / hide images | ||
| imageDisplayNode.addEventListener("change", function(event){ | ||
| event.preventDefault(); | ||
| state = event.target.checked ? "block" : "none"; |
There was a problem hiding this comment.
looks like this is creating a global variable
|
Good work. I would be great to see an updated README which explains what the project does and highlights any stretch goals. |
|
OK, cool. I'll update the readme file. I struggled with the articleTemplate function. It was clunky and long-winded. By the way, I'm really enjoying the recent projects - thanks for the classes and your help |
… searchForMatches function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.