responsive-news-reader - Ralph #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 15, 2018 14:33
dmitrigrabov
reviewed
Jul 1, 2018
| let page = 1; | ||
| let maxItemPerPage = 5; | ||
|
|
||
| function createRequest( |
dmitrigrabov
reviewed
Jul 1, 2018
| if (localStor === "show") { | ||
| checkbox.checked = true; | ||
| images.forEach(function(img) { | ||
| img.style.display = "block"; |
There was a problem hiding this comment.
it would be better to set a class whoch controls if image is displayed and then toggle the class rather than manipulating style directly. On larger projects this class could be re-used across other components
dmitrigrabov
reviewed
Jul 1, 2018
| <li id="next-page">Next</li> | ||
| </ul>`; | ||
| container.innerHTML = paginationUl; | ||
| // document |
There was a problem hiding this comment.
avoid committing commented out code
dmitrigrabov
reviewed
Jul 1, 2018
|
|
||
| // Show/hide buttons when needed | ||
| page === 1 | ||
| ? (document.querySelector("#prev-page").style.visibility = "hidden") |
There was a problem hiding this comment.
Setting visibility using a class would be better here than manipulating style
dmitrigrabov
reviewed
Jul 1, 2018
| if (e.target.className === "article__readlater btn") { | ||
| const articleTitle = e.target.getAttribute("data-title"); | ||
| liveNewsCollection.forEach(articleObj => { | ||
| return Object.keys(articleObj).find(articleKey => { |
There was a problem hiding this comment.
return here is not needed since forEach does not return a value
dmitrigrabov
reviewed
Jul 1, 2018
| toggleImages(); | ||
| pagination(page, totalPages); | ||
|
|
||
| window.scroll(0, 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.