Luke Sikuade News Reader #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| - [ ] Display images for tablet and desktop screens only | ||
| Simply download and unpack the .zip file onto your machine, then open up the index.html. |
| "uri" should be undefined the first time, but not subsequent times | ||
| for purposes of pagination. | ||
| */ | ||
| function grabData(uri) { |
There was a problem hiding this comment.
Rather than using if/else you can use default parameter values which will replace the parameter value when it is undefined. For example
function grabData(uri = url){
That way if uri is undefined, the url value will be applied instead
| //As they pass in, create list elements from them. | ||
| //Call populateNewsFeed on each one. | ||
| function createListElement(articleObject) { | ||
| /*CREATE THE LIST ITEM WITH ATTRIBUTES AND ARTICLE CONTENT */ |
There was a problem hiding this comment.
Would this be easier to generate using HTML string templates?
| } | ||
|
|
||
| //PROGRAM START | ||
| document.addEventListener("DOMContentLoaded", grabData()); |
|
Good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.