Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working version of News Reader #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolaGibson
Copy link

No description provided.

button.setAttribute("href", article.url);
div.appendChild(button);

// function articleSearch() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code can be removed so it does not take up space on the page

function displayData(articles) {
const stories = document.querySelector("#article");
articles.map(article => {
let div = document.createElement("div");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might easier to implement this part using HTML string templates

@@ -0,0 +1,74 @@
function displayData(articles) {
const stories = document.querySelector("#article");
articles.map(article => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't use the output of a map method, it's better to replace it with a forEach instead

}

.wrapper {
display: grid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see grid being used

@dmitrigrabov
Copy link
Contributor

It would be great to see more frequent commits. Also, update the README at the end to explain what you have done. That will make it easier to for reviewer to see what you have built. Also, potential employers might take a look at the README in future and an explanation of project will help them to understand what you can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants