My news reader #20
Open
My news reader #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d article template
…eds some serious polish still
…that brings in. Also decided it was about time to put a little formatting into the date. And also using the 100 results to populate a sorted list of top ten publishers for the query
| } | ||
|
|
||
| // api request to news api. Returns json and calls createArticles function | ||
| const getArticles = (page=1, excludedDomainsStr='', filterDomains="") => { |
| twentyArticles = hundredArticles.slice(startArticle,startArticle+20); | ||
| itemId = 0; | ||
| twentyArticles.forEach(article => { | ||
| itemId ++ |
There was a problem hiding this comment.
you can get the itemId using forEach index for example twentyArticles.forEach((article, index)){
| } | ||
|
|
||
| // add a listener to article creating 'click' event that takes user to URL | ||
| const clickArticle = (articleNode, url) => { |
There was a problem hiding this comment.
Would it not be easier to wrap the html with an <a> tag?
|
|
||
|
|
||
| // adds listeners that change the colour of the article the mouse is over - move to css | ||
| const mouseOverArticle = (articleNode) => { |
There was a problem hiding this comment.
This might be easier to achieve using CSS :hover
|
It would be great to see an updated README so other people looking at the repo in future can see what you have done, how it works, what technologies it uses |
|
BTW, if you don't need old.js, new.js and functionNames.js, you can delete them, commit and push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore old.js, new.js and functionNames.js .
Thanks!
Phil