Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive News App #15

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
af2b898
add html placeholder elements
joelamb Sep 12, 2018
2ad6942
add FF Meta VF to style.css
joelamb Sep 12, 2018
923c964
create article and add to timeline
joelamb Sep 14, 2018
ff0073b
add articles to timeline
joelamb Sep 14, 2018
882ef3b
time elapsed since publication with conditional plurals
joelamb Sep 14, 2018
3e90cbf
refactor
joelamb Sep 14, 2018
0d3ebdd
initialise and set News API URL
joelamb Sep 15, 2018
7a09181
pagination
joelamb Sep 15, 2018
abf877f
search
joelamb Sep 15, 2018
a06f16c
stop pagination nav beyond last page
joelamb Sep 15, 2018
90d767b
data filter to prevent stories without images or description loading
joelamb Sep 15, 2018
ba9410a
prevent empty search query submission
joelamb Sep 15, 2018
afd29f3
category navigation
joelamb Sep 15, 2018
7c74fbf
category nav refactoring
joelamb Sep 15, 2018
4933c62
search refactoring
joelamb Sep 15, 2018
bea0c24
mobile styling
joelamb Sep 15, 2018
0db9706
iPad styling
joelamb Sep 15, 2018
4f03b4d
iPad styling grid adjustment
joelamb Sep 15, 2018
9495ccb
iPad styling and functionality
joelamb Sep 16, 2018
5ec3fd2
desktop layout
joelamb Sep 16, 2018
60be008
generate and style popular stories sidebar
joelamb Sep 16, 2018
296acf4
redact Trump news
joelamb Sep 16, 2018
b76f729
italic styling with font-variant-settings
joelamb Sep 16, 2018
31f7d78
Comment and clean up
joelamb Sep 16, 2018
5b39150
comments and clean up
joelamb Sep 16, 2018
4e22bda
redact trump images with cute kitten
joelamb Sep 16, 2018
bc3aba7
Documentation of App features
joelamb Sep 16, 2018
093a026
refactoring redact behaviour
joelamb Sep 17, 2018
ba37237
comment out image redact function
joelamb Sep 17, 2018
50c443c
pagingation fix on category view
joelamb Sep 21, 2018
3c28911
category navigation
joelamb Nov 24, 2018
0ed0833
Procfile
joelamb Nov 24, 2018
2d91a32
demo link in README
joelamb Nov 24, 2018
dd670c1
Delete Procfile
joelamb Nov 24, 2018
cca4bae
Create now.json
joelamb Nov 28, 2018
982b54e
Merge pull request #1 from joelamb/joelamb-now-1
joelamb Nov 28, 2018
8828a9a
Revert "Create now.json"
joelamb Nov 28, 2018
af8b026
Merge pull request #2 from joelamb/revert-1-joelamb-now-1
joelamb Nov 28, 2018
1cfc435
Create now.json
joelamb Nov 28, 2018
a2d4129
Merge pull request #3 from joelamb/joelamb-now-1
joelamb Nov 28, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
category nav refactoring
  • Loading branch information
joelamb committed Sep 15, 2018
commit 7c74fbf403e7507ab0d6845f8a0221d3d4aa9c7d
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ const categories = document.querySelectorAll('.category');
categories.forEach(category => {
category.addEventListener('click', e => {
const topic = e.target.textContent;
console.log(topic);
if (topic === 'cycling') {
params.query = 'cycling bicycle cycle';
params.endpoint = 'everything';
Expand Down