Nicola's Film Search #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrigrabov
reviewed
Oct 4, 2018
src/components/App.js
Outdated
| handleClick(filmTitle) { | ||
| console.log(filmTitle); | ||
|
|
||
| const favouritesCopy = this.state.favouriteFilm.splice(0); |
There was a problem hiding this comment.
Splice mutates the original array by removing items from it and returning them. My guess you want to use slice here to create a copy
dmitrigrabov
reviewed
Oct 4, 2018
| } | ||
|
|
||
| handleChange(event) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
rather than passing up events from Search to App, it would better to extract event.target.value in Search and just send up the string. It makes life slightly easier as events get dealt with in the component they are created in and only the relevant values are passed up.
dmitrigrabov
reviewed
Oct 4, 2018
| } | ||
|
|
||
| render(){ | ||
| handleSubmit(event) { | ||
| event.preventDefault(); |
dmitrigrabov
reviewed
Oct 4, 2018
|
|
||
| removeFavouriteByIndex(index) { | ||
| console.log(index); | ||
| const favouriteCopy = this.state.favouriteFilm.splice(0); |
There was a problem hiding this comment.
As above, slice would be better here to avoid mutating the original array
|
Good work. Would be awesome to see more frequent commits and a README next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.