CP React Cinema Project #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incomplete - readme missing, not tidied up, functions unimplemented, unfinished styling. |
dmitrigrabov
reviewed
Oct 3, 2018
| super(); | ||
|
|
||
| this.state = { films: [], pageNum: 1, currentSearchFlim: "love", unFound: {gif: '', h6: ''}, hideButtons: true}; |
There was a problem hiding this comment.
It would be better to break out each property definition onto own line to make code easier to read
dmitrigrabov
reviewed
Oct 3, 2018
| render(){ | ||
| handleNext() { | ||
|
|
||
| // this.setState(prevState =>Object.assign({}, prevState, { pageNum: prevState.pageNum + 1 })) |
There was a problem hiding this comment.
commented out code should be removed to avoid clutter
dmitrigrabov
reviewed
Oct 3, 2018
| <div></div> | ||
| <div className="lower__buttons__wrapper"> | ||
| <button className="lower__button__2" onClick={this.handlePrevious} href="#top">Back</button> | ||
| <button className="lower__button__1" onClick={this.handleNext} href="#top" >Next</button> |
There was a problem hiding this comment.
button should not have an href
|
Very nice work, but a lot of commented out code that should be deleted. It adds quite a lot of clutter and makes code more difficult to read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.