Edem's react-cinema #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrigrabov
reviewed
Jul 1, 2018
|
|
||
| fetchingMovies(movie) { | ||
| //search for movie | ||
| console.log("Fetching Movies " + movie); |
There was a problem hiding this comment.
It's good practive to omit console.logs in committed files
dmitrigrabov
reviewed
Jul 1, 2018
| import React from "react"; | ||
| import MovieInfo from "./MovieInfo"; | ||
|
|
||
| function Movie(props) { |
There was a problem hiding this comment.
Minor point: destructuring here will save you having to type props in JSX
dmitrigrabov
reviewed
Jul 1, 2018
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| .App-header { | |||
There was a problem hiding this comment.
avoid using capitals for anything other than js classes or components. use lower case with dashes for CSS classes
dmitrigrabov
reviewed
Jul 1, 2018
| function Search(props) { | ||
| return ( | ||
| <div className='App-header'> | ||
| <form onSubmit={event => props.handleSubmit(event)}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.