Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotation for returning tuple #2177

Merged

Conversation

Quasar985
Copy link
Collaborator

Prerequisites

  • Reviewed the checklist

  • Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
    for the "CI / Unit Tests") to complete first. Failed Unit tests can be
    debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Removed an annotation in constellation_client. This was causing issues on the Linux machine, because it was running an old version of python. To remedy, a better description of the function and the expected return types were added in a comment above the function.

Alternate Designs

N/A

Why Should This Be In Core?

N/A

Benefits

Script works on old python versions

Possible Drawbacks

None

Verification Process

  1. Open consty,
  2. Tools -> Start Jupyter Notebook
  3. Import constellation_client
  4. Observe no errors are thrown when importing

Applicable Issues

#2176

@Quasar985 Quasar985 self-assigned this Aug 7, 2024
Copy link

sonarcloud bot commented Aug 7, 2024

@Quasar985 Quasar985 marked this pull request as ready for review August 7, 2024 05:53
@antares1470 antares1470 merged commit ccc84f7 into master Aug 11, 2024
3 checks passed
@antares1470 antares1470 deleted the bug/fix-python-annotations-for-old-python-version branch August 11, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants