Fix the Notes View tags filter

[Auriga2]

Fix the Notes View tags filter to update notes consistently upon user selection/deselection of tags

Prerequisites

• Reviewed the checklist

• Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
  for the "CI / Unit Tests") to complete first. Failed Unit tests can be
  debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Due to the Platform.runLater() in the updateSelectedTagsCombo , the selected tag filters were not updating before the UI is updated in the updateNotesUI() . It ( Platform.runLater() ) doesn't seem to be required because no GUI is updated in that function, hence removing it fixed the issue.

Alternate Designs

Moving the entire updateNotesUI() inside a Platform.runLater() but it'd degrade the performance

Why Should This Be In Core?

Benefits

Possible Drawbacks

Verification Process

Open a graph and Notes View. Perform some activities on the graph such as select a node, delete it

Select Auto notes filter and see notes appear for those activities

Select/Deselect tags under the Select tag(s) filter and verify it is only displaying the notes with matching tags.

Applicable Issues

#1854

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
No Duplication information