-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honour NO_COLOR
environment variable alongside CLICOLOR
#197
Comments
darimari21
added a commit
to darimari21/console
that referenced
this issue
Jan 18, 2024
darimari21
added a commit
to darimari21/console
that referenced
this issue
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While this crate follows https://bixense.com/clicolors/, several crates in the ecosystem (for example
tracing
) follow another convention of forcing tools not to print coloured output: https://no-color.org/I wonder if it wouldn't be feasible to support both conventions simultaneously in this crate. The unknown question is which convention should be prioritized. Personally, I think it doesn't matter and would probably check
NO_COLOR
afterCLICOLOR
.Relevant code, as far as I see, is only this chunk:
console/src/utils.rs
Lines 19 to 23 in de2f15a
The text was updated successfully, but these errors were encountered: