-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
white isn't white #177
Comments
White is the name of from ECMA-48 SGR 37, so in theory the name is correct. In many terminal color schemes this this is rendered as a light grey color (and some libraries refer to this specifically as Grey for this reason). In practice, the color you want is Bright White ( I'm not a maintainer here, but a maintainer of the Ratatui crate (which uses Grey because of historical reasons). |
When using the color white it isn't really white instead it's more a light gray.
here is a table of the 256 colors.
currently, only the first 8 (0-7) are used and white is mapped to 7 which isn't white
it would probably be good to add the first 16 colors to the color enum.
note:
if you are ok with this change I could do the change myself and open a PR
The text was updated successfully, but these errors were encountered: