fix(ci): aderyn target. #1073
Merged
fix(ci): aderyn target. #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnpm hoists dependencies to the workspace root and uses symlinks to link them under node_modules. Aderyn performs local compilation calling solc directly. Solc requires the target of symlinks to be whitelisted in allowed-paths. Unfortunately, Aderyn doesn't support passing in allowed-paths, nor does it pick them up from Foundry config. I also wasn't able to mimic a standard node_modules layout with pnpm, after trying various hoisting and linking settings. So we bite the bullet and perform an ordinary npm install to make Aderyn happy.
2447754
to
e0b73f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause:
node_modules.--allow-paths.Unfortunately:
node_moduleslayout with pnpm, after trying various hoisting and linking settings.So we bite the bullet and perform an ordinary npm install to make Aderyn happy.
Also rewrote the
check_aderyn.shscript to make it POSIX compliant, so I could run it on macOS to verify the fix.