Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with whitespace consisting broken path #901

Open
wants to merge 1 commit into
base: 6.0.1-post
Choose a base branch
from

Conversation

suneeta-mall
Copy link

Description

What behavior does this PR change, and why?
The cloud stack destroy script fails if path consists of whitespace:

./ccloud_stack_destroy.sh stack-configs/java-service-account-164390.config                     
./ccloud_stack_destroy.sh: line 6: <> No such file or directory
./ccloud_stack_destroy.sh: line 7: <>: No such file or directory
./ccloud_stack_destroy.sh: line 9: ccloud::validate_version_ccloud_cli: command not found

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

@ybyzek
Copy link
Contributor

ybyzek commented Jan 11, 2021

@suneeta-mall thanks for the PR.

  1. Are both the double quotes and curly braces required, or would just double quotes be sufficient?
  2. This methodology is used in other places in this repo. We should consider whether this PR should address all instances:
ccloud/ccloud-stack/ccloud_stack_destroy.sh:source $DIR/../../utils/helper.sh
ccloud/ccloud-stack/ccloud_stack_destroy.sh:source $DIR/../../utils/ccloud_library.sh
ccloud/create_ksqldb_app.sh:source $DELTA_CONFIGS_DIR/env.delta
ccloud/start-docker.sh:source $DELTA_CONFIGS_DIR/env.delta
ccloud/start.sh:source $DELTA_CONFIGS_DIR/env.delta
clients/cloud/java-springboot/startStreams.sh:source $DELTA_CONFIGS_DIR/env.delta
clients/cloud/java-springboot/startProducerConsumer.sh:source $DELTA_CONFIGS_DIR/env.delta
cloud-etl/create_ksqldb_app.sh:source $DELTA_CONFIGS_DIR/env.delta
cloud-etl/read-data.sh:source $DELTA_CONFIGS_DIR/env.delta
cloud-etl/start.sh:source $DELTA_CONFIGS_DIR/env.delta
microservices-orders/start-ccloud.sh:source $DELTA_CONFIGS_DIR/env.delta
multiregion/scripts/start.sh:source ${DIR}/../.env
utils/helper.sh:source "${DIR_HELPER}/config.env"

Copy link

cla-assistant bot commented Apr 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Suneeta Mall seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants