Patch to fix esmpy import for esmpy >= 8.4.0 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to make sure `regrid2.ESMFREgrid` is available.
xylar
requested review from
dnadeau4,
doutriaux1,
downiec and
jasonb5
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Equivalent to #87 but for the |
…nda-forge-pinning 2023.08.01.09.17.58
|
@conda-forge-admin, please restart CI |
xylar
commented
Aug 1, 2023
| @@ -69,6 +70,7 @@ test: | |||
| - python -c 'import regrid2' | |||
| - python -c 'import regrid2._regrid' | |||
| - python -c 'import regrid2._scrip' | |||
| - python -c 'from regrid2 import ESMFRegrid' | |||
There was a problem hiding this comment.
@chengzhuzhang, hopefully this check will prevent issues like E3SM-Project/e3sm_diags#711 from happening in the future.
There was a problem hiding this comment.
It looks like regridding behavior gets back to normal with this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to make sure
regrid2.ESMFREgridis available.Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)