Patch to fix disabling mpi4py in cdms2.dataset
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `cdscan` to work when MPI is disabled, we need to be able to call `setNetcdfUseParallelFlag(0)`. Before this patch, this call attempted to raise an error but there was a typo in the error name (`CDSMError` instead of `CDMSError`), causing added confusion. We only want to raise an error if the code is attempting to enable parallel NetCDF usage but MPI is disabled.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
|
This has been tested as described here: E3SM-Project/zppy#95 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
cdscanto work when MPI is disabled, we need to be able to callsetNetcdfUseParallelFlag(0). Before this patch, thiscall attempted to raise an error but there was a typo in the error name (
CDSMErrorinstead ofCDMSError), causing added confusion. We only want to raise an error if the code is attempting to enable parallel NetCDF usage but MPI is disabled.This patch is equivalent to CDAT/cdms#439
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)