Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement a way to clear inline modifiers #478

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat: implement a way to clear inline modifiers #478

merged 3 commits into from
Sep 4, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

Create a way to remove all previous inline modifiers

Changes

  • Create _WidgetModifiersDataDtoCleaner and modify the merge logic

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 6:11pm

@github-actions github-actions bot added the mix label Sep 4, 2024
@tilucasoli tilucasoli changed the title Feat/clear modifiers feat: implement a way to clear inline modifiers Sep 4, 2024
leoafarias
leoafarias approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 9993dda into main Sep 4, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/clear-modifiers branch September 4, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias