Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button supports component builder #444

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

  • Button now supports building a spinner

Changes

  • add a builder in RxButton and RxBlankButton

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

Is there any additional context or documentation that might be helpful for reviewers?

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Aug 9, 2024 6:49pm

@github-actions github-actions bot added the remix label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

DCM report

✅ no issues found!

Full report: https://github.com/conceptadev/mix/runs/28583441895

@tilucasoli tilucasoli merged commit 0f81f15 into main Aug 9, 2024
7 checks passed
@tilucasoli tilucasoli deleted the feat/remix-button-loading-builder branch August 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant