Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for final new line #545

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jul 15, 2024

Have yet to encounter any evidence whatsoever that this check "prevented" us from experiencing any issues.

  • All compilers I've tested will accept files that don't end in a newline, even with the most pedantic level of errors and warnings
  • Have not found any evidence in Conan Center, for any version, that a compiler ever failed due to lack of blank end of file line - this seems to be more of a theoretical hook
  • C++ 11 and onwards does not require it
  • Most evidence online of a compiler warning with the text " warning: no newline at end of file." point to gcc 15 years ago or longer

Python, cmake, yaml files do not "require" this - yet to experience any errors

This only adds noise to conan center PRs - and unnecessary failures.

@uilianries uilianries merged commit 507bfa4 into master Jul 15, 2024
2 checks passed
@uilianries uilianries deleted the lcc/remove-check-for-endline branch July 15, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants