Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan list ... --format=compact for package revisions #16490

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Jun 17, 2024

Changelog: Bugfix: Fix conan list ... --format=compact for package revisions.
Docs: Omit

I might have gone a bit overboard with the test parametrization, the improtant few are the last ones, but they don't hurt either

Checking the code, I actually can't see where a package revision would get the info key, but I've left it instead of removing it in case I'm not finding it in some other part of the codebase

@AbrilRBS AbrilRBS added this to the 2.5.0 milestone Jun 17, 2024
@memsharded
Copy link
Member

Checking the code, I actually can't see where a package revision would get the info key, but I've left it instead of removing it in case I'm not finding it in some other part of the codebase

yes, that code is fired when no last #* is added, so:

conan list zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:7bfde258ff4f62f75668d0896dbddedaa7480a0f -f=compact

will read the info and display it.

Maybe the discussion would be if we want to list the info part also when listing the package-revisions, at the moment it is not added because it is a different API call.

@czoido czoido merged commit 05450d0 into conan-io:develop2 Jun 17, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/fix-list-compact-revisions branch June 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants