Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wildcard in rm_safe call #16105

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Apr 18, 2024

Changelog: Feature: Allow * wildcard as subsetting in in rm_safe.
Docs: conan-io/docs#3697

To check with the team, came up in a conversation with @czoido when trying to debug the openjdk permission issues

Note that this is just a draft, because this is pretty similar to doing

 for subsetting in self.settings.compiler.fields:
     self.settings.compiler.rm_safe(subsetting)

so we might now want to have two ways of doing the same thing, even if the current syntaxt is a bit unknown (There's something to say from me just realizing about the fields property)

@AbrilRBS AbrilRBS requested a review from czoido April 18, 2024 15:08
Copy link
Contributor

@czoido czoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think this could be useful 👏

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AbrilRBS AbrilRBS marked this pull request as ready for review April 18, 2024 19:43
@AbrilRBS AbrilRBS added this to the 2.3.0 milestone Apr 18, 2024
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@franramirez688 franramirez688 merged commit 517e2b7 into conan-io:develop2 Apr 19, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/rm_safe_wildcard branch April 19, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants