Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adopt new docker compose specifications #75

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Jun 26, 2024

No description provided.

The latest stable version of docker-compose no longer requires the `version` field.
`docker compose` now supports both `compose.yml` and `docker-compose.yml`
@azzamsa
Copy link
Contributor Author

azzamsa commented Jun 26, 2024

I have read the CLA Document and I hereby sign the CLA

@zicklag
Copy link
Collaborator

zicklag commented Jun 28, 2024

What is the reason for removing the version? Doesn't that make it go back to the old pre-2.0 version of the compose format?

@secondtruth
Copy link

What is the reason for removing the version? Doesn't that make it go back to the old pre-2.0 version of the compose format?

version is obsolete now. docker compose up throws a warning if it is used.

@azzamsa
Copy link
Contributor Author

azzamsa commented Jun 28, 2024

Technically you can still define it… But you will get the warning you observed, and it won’t be used, as docker compose v2 (=the cli plugin) will always use the latest version of the compose file schema. -- Metin Y.Leader

From Docker-compose.yml: version is obsolete - Docker Hub - Docker Community Forums

@zicklag zicklag merged commit 035aa7d into commune-os:main Jun 29, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
@azzamsa azzamsa deleted the fix-docker-compose-warning branch July 3, 2024 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants